Skip to content

venv/scripts/common/activate should use uname instead of $OSTYPE to detect Cygwin and MSYS #112507

New issue
New issue
Closed
Closed
venv/scripts/common/activate should use uname instead of $OSTYPE to detect Cygwin and MSYS#112507
Labels
stdlibStandard Library Python modules in the Lib/ directorytopic-venvRelated to the venv moduletype-bugAn unexpected behavior, bug, or error
@J-M0

Description

@J-M0
J-M0
opened on Nov 29, 2023

Bug report

Bug description:

The venv activate script uses the $OSTYPE variable to determine if it's running on Cygwin or MSYS.

cpython/Lib/venv/scripts/common/activate

Lines 41 to 49 in fb202af

# on Windows, a path can contain colons and backslashes and has to be converted:
if [ "${OSTYPE:-}" = "cygwin" ] || [ "${OSTYPE:-}" = "msys" ] ; then
# transform D:\path\to\venv to /d/path/to/venv on MSYS
# and to /cygdrive/d/path/to/venv on Cygwin
export VIRTUAL_ENV=$(cygpath "__VENV_DIR__")
else
# use the path as-is
export VIRTUAL_ENV="__VENV_DIR__"
fi

$OSTYPE is not defined by POSIX. It's provided by bash and zsh, but may not be present in other shells like dash. The uname command is always available in any shell and should be used instead.

CPython versions tested on:

3.12

Operating systems tested on:

Windows

Linked PRs

Metadata

Metadata

Assignees

No one assigned

    Labels

    stdlibStandard Library Python modules in the Lib/ directorytopic-venvRelated to the venv moduletype-bugAn unexpected behavior, bug, or error

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions