@overload decorator on compiled functions is not tested #96478

New issue

Copy link

New issue

Copy link

Closed

Closed

@overload decorator on compiled functions is not tested#96478

Copy link

Labels

testsTests in the Lib/test dirTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Description

sobolevn

opened on Sep 1, 2022

Issue body actions

If I change this line

cpython/Lib/typing.py

Line 2584 in a91f255

pass

to be

    try:
        _overload_registry[f.__module__][f.__qualname__][f.__code__.co_firstlineno] = func
    except AttributeError:
        # Not a normal function; ignore.
        raise # pass

test_typing continues to pass as expected. I think it is dangerous, because we can accidentally break something and not notice.

I will send a simple test case to catch this: we should not fail.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

Labels

testsTests in the Lib/test dirTests in the Lib/test dirtopic-typingtype-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions