Redundant NULL check in profile_trampoline function (sysmodule.c) #96715

New issue

Copy link

New issue

Copy link

Closed

#96716

Closed

Redundant NULL check in profile_trampoline function (sysmodule.c)#96715

#96716

Copy link

Assignees

Description

chgnrdv

opened on Sep 9, 2022

Issue body actions

Code in profile_trampoline function checks if arg argument value is equal to NULL and in this case assigns Py_None to it

cpython/Python/sysmodule.c

Lines 954 to 956 in 88a7f66

	if (arg == NULL) {
	arg = Py_None;
	}

The only place where arg is used in profile_trampoline is this call

cpython/Python/sysmodule.c

Line 959 in 88a7f66

PyObject *result = call_trampoline(tstate, self, frame, what, arg);

But similar check is already done by call_trampoline function

cpython/Python/sysmodule.c

Line 930 in 88a7f66

stack[2] = (arg != NULL) ? arg : Py_None;

My suggestion is to remove excess check from profile_trampoline.

Linked PRs

• gh-96715 Remove redundant NULL check in profile_trampoline function #96716

Reactions are currently unavailable

Metadata

Metadata

Assignees

• 
  pablogsal

Labels

No labels

No labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions