node foundation proposed express WG governance #2871
Conversation
|
Hi! Thank you for your pull request! Can the code of conduct be inlined into this repository? Having the entire code simply a link to another means that people who are offline cannot read it & there is a chance of it's terms changing without the current community of the repository realizing. The same goes for the Moderation Policy. Can the names of the files be consistent in some form? Right now we have "CODE_OF_CONDUCT", "GOVERNANCE", "Contributing", "ModerationPolicy". Let's pick a single style and stick with it, please :) |
GOVERNANCE.md
Outdated
There was a problem hiding this comment.
This document has no heading level 1. Please Use heading with semantic meaning, rather than skipping levels just to get the desired font size in a given stylesheet.
|
When this get's closer to being ready to land I can definitely look at making those changes. Currently it follows the boilerplate in the Node.js TSC templates and is a work in progress draft. It is not yet ready to land. |
There was a problem hiding this comment.
I don't think this link adequately describes what Consensus Seeking is. In addition, the Wikipedia article may change at any time, without the knowledge of the WG, creating misleading information.
|
Hi @jasnell, I'm confused by your comment. Does this mean that this pull request is not open for public commenting? |
Contributing.md
Outdated
There was a problem hiding this comment.
This link does not work, as there is no governance folder.
|
Here is the mirror pull request to the documentation: expressjs/expressjs.com#565 |
|
By all means comment away, that's what PRs are for. There are likely to be
|
|
@jasnell this is out of date |
|
Yep, will update a bit later this week |
|
@Fishrock123 ... updated, still plenty of details to fill in |
|
Hey @jasnell, it looks like a few of my comments did not make it into your latest push and you didn't rely to them. Do you have any comments on them? |
|
@dougwilson ... I'm a bit backlogged on github notifications so I think I just missed them... I'll be going through this again in more detail later this week but I really wanted to hold off making too many substantial changes until after the first TC meeting. |
GOVERNANCE.md
Outdated
There was a problem hiding this comment.
What is the purpose of cluttering up the main code repository with meeting minutes? I think it would make sense to have a dedicated repository to hold these things (Express has an entire GitHub organization it can use).
There was a problem hiding this comment.
these can go anywhere really, they just need to be public. As I've said before, most of this is boilerplate drawn from the TSC's templates. It can be changed by the express TC. The TC can choose to organize this however it wishes.
There was a problem hiding this comment.
Right, I know it's just boilerplate and can be changed. I thought this was the place to discuss these changes. Sorry if I am mistaken.
There was a problem hiding this comment.
I don't understand the purpose of opening a pull request if we're not allowed to comment and discuss on it.
There was a problem hiding this comment.
O.o comment away! I'm just making sure it's clear that this is largely place holder text at the moment.
There was a problem hiding this comment.
Right, what @jasnell meant was that once the TC passes it, changes to it need to be ratified by the TC to be merged.
We can change a lot if necessary, although there are certain Baseline things (CoC, DCO, MIT License).
* Update location of the repo * Fix a few broken links * Move the code of conduct text into the repo * s/WG/TC * Additional metadata into the Readme (placeholder)
|
rebased with commits fixed up.. @dougwilson took care of a few of those formatting and issue links. The rest of the text can be looked at once the TC meets and starts to nail down the exact process. Please definitely continue to flag that parts that may not make sense for express (probably 99% of the text was just copied straight over from the templates) |
|
BTW, there's a new base contribution policy you may want to use as a starting point instead. https://github.com/nodejs/TSC/blob/master/BasePolicies/CONTRIBUTING.md It does a better job of explaining some of this than the Node.js Core policy you're starting from. |
|
@mikeal +1 ... Will look at integrating that a bit later this week |
|
@expressjs/express-tc |
|
LGTM. We'll want to update the location of the expressjs.com repo in |
|
LGTM 👍 I agree with @dougwilson on that we should put meeting minutes somewhere else than in the main code repository. Maybe in a dedicated repo? |
|
So this pull request had gotten lost in the shuffle for a while. Since it we have merged in governance, code of conduct, etc. so we got everything incorporated now 👍 |
Per the proposal to add express to the Node.js Foundation incubator (nodejs/TSC#39) an Express WG under the Node.js TSC would be chartered to oversee the nodejs/express github repository. Per the TSC guidelines, every WG needs a minimum set of governance policies in place that describe how the WG will operate. This adds an initial draft that is based directly on the base policy templates provided by the TSC.