Skip to content

CAM: Refactor stock used as boundary to be distinct from regular stock #25960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Connor9220 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CAM: Refactor stock used as boundary to be distinct from regular stock #25960

Connor9220 wants to merge 1 commit into from
+29 −1

Conversation

@Connor9220
Copy link
Contributor

@Connor9220 Connor9220 commented Dec 4, 2025 •
edited
Loading

This commit makes boundary stock objects distinct from regular stock by setting a boundary flag and label, and prevents editing of boundary objects in the job view provider.

src/Mod/CAM/Path/Dressup/Boundary.py:

  • Add promoteStockToBoundary method, set boundary properties, handle missing stock/shape

src/Mod/CAM/Path/Main/Gui/Job.py:

  • Block editing for objects flagged as boundary stock

Before/After
boundary-before-after

New property (Normally Hidden)
Screenshot from 2025-12-06 12-33-42

@Connor9220
CAM: Refactor stock used as boundary to be distinct from regular stock
8e2dc8c 
This commit makes boundary stock objects distinct from regular stock by
setting a boundary flag and label, and prevents editing of boundary
objects in the job view provider.

src/Mod/CAM/Path/Dressup/Boundary.py:
- Add promoteStockToBoundary method, set boundary properties, handle
missing stock/shape

src/Mod/CAM/Path/Main/Gui/Job.py:
- Block editing for objects flagged as boundary stock
@github-actions github-actions bot added the Mod: CAM Related to the CAM/Path Workbench label Dec 4, 2025
@maxwxyz maxwxyz added the Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other... label Dec 4, 2025
@maxwxyz maxwxyz added this to the 1.2 milestone Dec 4, 2025
@sliptonic
Copy link
Member

sliptonic commented Dec 6, 2025

I don't understand this.
Is there an issue?
Are Before/After pics appropriate?
Is anything testable (unit test coverage)?

@Connor9220
Copy link
Contributor Author

Connor9220 commented Dec 6, 2025

I don't understand this. Is there an issue? Are Before/After pics appropriate? Is anything testable (unit test coverage)?

I had shown you this in a call a few days back. The boundary dressup make use of stock to specify a region to include / exclude for operations. If you click on THAT stock item in a attempt to modify it (like you can normal stock) it opens up the Job, and you end up modify the job's stock instead of the dressup's stock. This PR changes the name from Stock to Boundary, and the IsBoundary property.

@tarman3
Copy link
Contributor

tarman3 commented Dec 6, 2025 •
edited
Loading

Renaming from Stock to Boundary looks good,
but I never meet this issue and after several attempts I can not get name Stock for shape inside DressupBoundary
In all attempts the names is different

Please write steps to reproduce this issue

Screenshot_20251206_194800_lossy

@Connor9220
Copy link
Contributor Author

Connor9220 commented Dec 6, 2025

Renaming from Stock to Boundary looks good, but I never meet this issue and after several attempts I can not get name Stock for shape inside DressupBoundary In all attempts the names is different

Please write steps to reproduce this issue

Screenshot_20251206_194800_lossy

You have it. You have Stock002 in your dressup, Double click on it. It brings up the Jobs task panel.
Why is a boundary have anything stock in the name? Why does it bring up the Job task panel?

@tarman3
Copy link
Contributor

tarman3 commented Dec 6, 2025

Now it clear
Usually I do not use task panels, and that is why I do not meet this issue

@Connor9220
Copy link
Contributor Author

Connor9220 commented Dec 6, 2025

StockvsBoundary-2025-12-06_12.58.39.MP4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Mod: CAM Related to the CAM/Path Workbench Type: Other Tasks, refactoring, quality improvement, actions, dependencies, packaging, translations or other...

Projects

CAM "Big Board"
Status: No status
Merge Queue
Status: Queue

Milestone

1.2

Development

Successfully merging this pull request may close these issues.

4 participants

@Connor9220 @sliptonic @tarman3 @maxwxyz