feat(vite): improved workspace and windows compatibility#10959
feat(vite): improved workspace and windows compatibility#10959NathanWalker wants to merge 43 commits intomainfrom
Conversation
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx test apps-automated -c=android |
❌ Failed | 21m 51s | View ↗ |
nx run-many --target=test --configuration=ci --... |
✅ Succeeded | <1s | View ↗ |
☁️ Nx Cloud last updated this comment at 2026-03-16 14:58:01 UTC
a4a2258 to
74c041a
Compare
74c041a to
6de0d07
Compare
b6f85fc to
40788e3
Compare
…k for quick core build verify against apps
Type checking diagnostics come from the project's `tsconfig.json`. By default, the build follows `compilerOptions.noEmitOnError` to decide whether type errors should fail the build. If you want to override that behavior for Vite, pass a `typeCheck` option to the framework helper.
| indexAsInt--; | ||
| } | ||
| } else if (types.isString(index)) { | ||
| while (result && result.typeName !== index) { |
There was a problem hiding this comment.
What is the intention of this change? Something to do with Vite having trouble to parse keys of $parents references in XML?
There was a problem hiding this comment.
Good question, it makes string-based ancestor lookup compat with Vite runtime naming differences, where relying on typeName alone is brittle. Now, bindings like $parents['StackLayout'] can still resolve even if the runtime name is unstable, because the fallback uses cssType = stacklayout.
Uh oh!
There was an error while loading. Please reload this page.