Kernel: Validate ACPI checksums #26464
Open
+90
−18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for there to be multiple RSDP tables in memory, but only a single one of them should have a valid checksum. In addition to the RSDP, this also adds checksum validation for the rest of the tables (which is now done as a part of the signature check). This doesn't seem to lead to any behavior change when running in QEMU, but might have an impact on real hardware or other virtualizers.
I've also included an extra commit that I had around locally that just asserts that
s_hardware_timersis empty before initializing the PIT and RTC since we move on to assume that that was in fact the case.