Skip to content

Conversation

@implicitfield
Copy link
Contributor

@implicitfield implicitfield commented Dec 6, 2025

It's possible for there to be multiple RSDP tables in memory, but only a single one of them should have a valid checksum. In addition to the RSDP, this also adds checksum validation for the rest of the tables (which is now done as a part of the signature check). This doesn't seem to lead to any behavior change when running in QEMU, but might have an impact on real hardware or other virtualizers.

I've also included an extra commit that I had around locally that just asserts that s_hardware_timers is empty before initializing the PIT and RTC since we move on to assume that that was in fact the case.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Dec 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 pr-needs-review PR needs review from a maintainer or community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant