systemvmtemplate-register: correctly update existing template name in config#12703
systemvmtemplate-register: correctly update existing template name in config#12703shwstppr wants to merge 3 commits intoapache:mainfrom
Conversation
…n config When existing template is found for the required version then update the router hypervisor template config correctly. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the System VM template upgrade/registration flow where, when an existing SYSTEM template is detected (including via the URL-path fallback lookup), the global/per-zone router template configuration could be updated with the metadata template name instead of the actual registered template name.
Changes:
- Update
updateRegisteredTemplateDetails(...)to pass the persisted template’s name (templateVO.getName()) intoupdateConfigurationParams(...)instead oftemplateDetails.getName().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12703 +/- ##
============================================
- Coverage 18.02% 18.02% -0.01%
- Complexity 16450 16451 +1
============================================
Files 5968 5968
Lines 537086 537086
Branches 65961 65961
============================================
- Hits 96819 96818 -1
Misses 429347 429347
- Partials 10920 10921 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16939 |
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
Tested the upgrade from a 4.22 env to the pr package
The global settings values was correctly set to the existing values
router.template.kvm >> SystemVM Template (KVM)
router.template.vmware >> SystemVM Template (vSphere)
router.template.xenserver >> SystemVM Template (XenServer)
Before the fix it was incorrectly set to
systemvm-kvm-4.22.0-x86_64
|
@blueorangutan test |
|
@kiranchavala could we rerun the smoke tests here? |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17180 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Description
When an existing template is found for the required version, update the router hypervisor template config correctly.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?