Add PKCE support to SSO get_profile_and_token method#2
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
Add PKCE support to SSO get_profile_and_token method#2devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Add optional code_verifier parameter to get_profile_and_token in SSO and AsyncSSO - Update SSOModule protocol to include code_verifier parameter - Add test coverage for PKCE flow in SSO module - Align SSO implementation with User Management's PKCE support Co-Authored-By: Deep Singhvi <deep@buildwithfern.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds PKCE (Proof Key for Code Exchange) support to the SSO module's
get_profile_and_tokenmethod by introducing an optionalcode_verifierparameter. This brings the SSO module into alignment with the User Management module, which already supports PKCE flows viaauthenticate_with_code.Changes
code_verifierparameter toget_profile_and_tokenin bothSSOandAsyncSSOclassesSSOModuleProtocol to include the new parameterImplementation Details
The
code_verifierparameter is optional and only included in the API request when provided:This is backward-compatible - existing code continues to work without changes.
Testing
test_get_profile_and_token_with_code_verifierverifies the parameter is correctly included in the request@pytest.mark.sync_and_asyncHuman Review Checklist
/sso/tokenendpoint acceptscode_verifierparameter (most important - I assumed this based on user request)user_management.authenticate_with_codeDocumentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.
Link to Devin run: https://app.devin.ai/sessions/0c9b40ba6db24b4db13880d75091292e
Requested by: Deep Singhvi (deep@buildwithfern.com) (@dsinghvi)