feat!: Support SQLAlchemy 2.0, backwards compatibility for 1.4.16+#920
feat!: Support SQLAlchemy 2.0, backwards compatibility for 1.4.16+#920sharoonthomas wants to merge 47 commits intogoogleapis:mainfrom
Conversation
This patch makes this library backward incompatible for versions of SQLAlchemy < 2.0. Fixes googleapis#510
|
Included another bugfix related to |
| @@ -1 +0,0 @@ | |||
| sqlalchemy>=1.4.13,<2.0.0 | |||
There was a problem hiding this comment.
For 3.9, does it make sense to set a specific version, much as we did for 3.8?
if setup.py etc have the right minimum version of python, then it prolly doesn't matter. just trying to think of whether I am missing anything.
There was a problem hiding this comment.
It seems our minimum is 3.8 in setup.py under classifiers, should I add this constraint to 3.9 then? I don't think its necessary since we bumped our minimum version to >=1.4.16
| def test_update(self): | ||
| t = self.tables.plain_pk | ||
| connection = config.db.connect() | ||
| # Had to pass in data as a dict object in 2.0 |
There was a problem hiding this comment.
This seems like a comment for you. Is this supposed to be a comment for future readers?
There was a problem hiding this comment.
Yes I left the comment to justify the change I made to this compliance test
chalmerlowe
left a comment
There was a problem hiding this comment.
This is looking good.
I have a few comments and questions.
I need to confirm what we wanna do about making this a prerelease.
What kind verbiage we might wanna add to something like the README.md.
Let's touch base on Tuesday about next steps.
|
A pre-release version of python-bigquery-sqlalchemy has been released with coverage for 1.4 AND 2.0. based in part on the code in this PR. Gonna close this PR as complete. As feedback on the pre-release rolls in, we will update the above branch and ultimately merge with main when ready. |
|
This PR is now a part of prerelease v1.11.0.dev0. Closing this again |
|
Thanks @kiraksi Really appreciate your team's commitment to maintaining the SQLA dialect. |
This patch makes this library backward incompatible for versions of SQLAlchemy < 1.4.16.
Fixes #510