Use weakref finalize to close sqlite.conenctions#15152
Open
mroeschke wants to merge 1 commit intoipython:mainfrom
Open
Use weakref finalize to close sqlite.conenctions#15152mroeschke wants to merge 1 commit intoipython:mainfrom
mroeschke wants to merge 1 commit intoipython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe closes #15128. (We can sometimes see a similar
ResourceWarningwhen running the pandas tests suite)weakref.finalizeis the recommended way to run cleanup routines compared to__del__https://docs.python.org/3/library/weakref.html#comparing-finalizers-with-del-methods, so defined aself._finalizerto close thesqlite3.Connection. Additionally, adds a"error::ResourceWarning"warning filter to pytest so these warnings are treated as errors.