Fix use of deprecated sass lighten() and darken()#1548
Open
Fix use of deprecated sass lighten() and darken()#1548
lighten() and darken()#1548Conversation
|
This would be nice to fix :-) |
Member
Author
|
For @emiltin (and others) - copying over my comment from the issue (as it should help you resolve in the mean time): Ah - okay, slightly bad news. Users of the I will have to think about a way to resolve this issue in the general case. I think it's unlikely I will push a fix very quickly (especially as my bandwidth has been awful recently). My suggestion is to either:
sass:
quiet_deps: trueSorry for the confusion! Unfortunately, a general solution is slightly out of my hands unless we drop support for |
usta
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Jan 7, 2025
We will remove it after just-the-docs/just-the-docs#1548 merged. and jekyll/jekyll#9686 fixed completely
usta
added a commit
to endoflife-date/endoflife.date
that referenced
this pull request
Jan 9, 2025
We will remove it after just-the-docs/just-the-docs#1548 merged. and jekyll/jekyll#9686 fixed completely
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sass has deprecated the
lighten()anddarken()functions.color.adjustis a drop-in replacement, but does require importingsass:color. This is a problem, since this module only (?) exists in dart-sass, which earlier versions of the Jekyll gem (most notably:pages-gemusers) will not have access to.Closes #1541.