MNT: Use '--pytest-test-first' option for naming clarity#23341
Merged
tacaswell merged 1 commit intomatplotlib:mainfrom Jun 24, 2022
Merged
Conversation
* Use '--pytest-test-first' option over '--django' for name-test-tests for greater clarity of convention. * Amends PR 23213
tacaswell
approved these changes
Jun 24, 2022
Member
|
This only affects the pre-commit config and those test have already passed. Merging on a single review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
--pytest-test-firstoption over--djangofor name-test-tests for greater clarity of convention. While this commit is somewhat trivial (there is no change in functionality) I personally think that as a developer havingpytestin the option name makes more sense as it is enforcing thepytestdefault style of naming convention (and matplotlib doesn't use Django).pre-commit/pre-commit-hooksv4.3.0when I made PR DEV: Add name-tests-test to pre-commit hooks #23213 otherwise I would have just applied it then. Sorry about that.For further reference see:
PR Checklist
Tests and Styling
pytestpasses).flake8-docstringsand runflake8 --docstring-convention=all).Documentation
doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).