Skip to content

ci: Fix image preload with multiple conflicts#30274

Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic:fix-preload
Jul 9, 2025
Merged

ci: Fix image preload with multiple conflicts#30274
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic:fix-preload

Conversation

@QuLogic
Copy link
Member

@QuLogic QuLogic commented Jul 8, 2025

PR summary

I only tested #30231 with a single conflict. Unfortunately, the variable quoting did not work when there were multiple conflicts. This PR should fix that (and currently has a test change to verify it.)

PR checklist

@QuLogic QuLogic added this to the v3.11.0 milestone Jul 8, 2025
@QuLogic QuLogic added the CI: testing CI configuration and testing label Jul 8, 2025
@github-project-automation github-project-automation bot moved this to Waiting for other PR in Font and text overhaul Jul 8, 2025
@QuLogic QuLogic changed the title Fix preload ci: Fix image preload with multiple conflicts Jul 8, 2025
@QuLogic QuLogic moved this from Waiting for other PR to Ready for Review in Font and text overhaul Jul 8, 2025
@QuLogic
Copy link
Member Author

QuLogic commented Jul 8, 2025

Since this passed on 854caff, I've dropped that commit.

@QuLogic QuLogic merged commit 572540d into matplotlib:text-overhaul Jul 9, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this from Ready for Review to Done in Font and text overhaul Jul 9, 2025
@QuLogic QuLogic deleted the fix-preload branch July 9, 2025 05:45
@QuLogic
Copy link
Member Author

QuLogic commented Jul 9, 2025

Arg, I seem to have accidentally committed the mlab bits here instead of #30273. But anyway, it should get joined up when main is merged into this branch again.

wavebyrd pushed a commit to wavebyrd/matplotlib that referenced this pull request Mar 13, 2026
ci: Fix image preload with multiple conflicts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: testing CI configuration and testing

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants