Drop axis_artist tickdir image compat, due to text-overhaul merge.#31281
Merged
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom Mar 13, 2026
Merged
Drop axis_artist tickdir image compat, due to text-overhaul merge.#31281QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
QuLogic merged 1 commit intomatplotlib:text-overhaulfrom
Conversation
5 tasks
QuLogic
reviewed
Mar 11, 2026
Member
QuLogic
left a comment
There was a problem hiding this comment.
You can rebase and drop that first commit now; the original PR has been merged to this branch via main.
Contributor
Author
|
Done (including the style clarification). |
QuLogic
reviewed
Mar 11, 2026
lib/mpl_toolkits/axisartist/tests/test_grid_helper_curvelinear.py
Outdated
Show resolved
Hide resolved
Also replace style='default' by style='mpl20'.
QuLogic
approved these changes
Mar 12, 2026
Member
QuLogic
left a comment
There was a problem hiding this comment.
LGTM, when checking the test images locally.
ksunden
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Baseline image updates for #30369, taking advantage of the text-overhaul regen to squeeze in the changes. See discussion at #30369 (review). Note that I had to rebase the first (feature-implementing) commit as well, because it already touched the tests.
PR summary
AI Disclosure
PR checklist