ENH: Ignore empty text for tightbbox#31285
Conversation
You have to start with the images from the |
|
Makes sense, that worked. Images here updated - let me know if I should be retargeting those to |
|
No need, I'll take care of updating that branch when this is approved. |
5725832 to
8095b72
Compare
8095b72 to
d772043
Compare
|
Sorry, accidentally pushed the wrong commit to strip out the test images from here. Should be good again, and ready for merging, as I've put the new images on the |
|
I think your diagnosis was correct - remove_text just sets the strings to empty I think and their existence meant they still had anchor points that were causing the tightbbox to include them. |
…x_empty ENH: Ignore empty text for tightbbox
PR summary
This ignores empty or hidden text for tightbbox, dedicating more space to the plot in tight & constrained layouts. Some of the constrained layout images are larger for reasons I don't fully understand, but it's probably something to do with those invisible text bboxes being used to calculate internal padding.
Targeting the text-overhaul branch.
@QuLogic when I regenerate baseline images, it adds a much larger diff than expected. How are you handling those on this branch?
AI Disclosure
None.
PR checklist