Skip to content

feat(txpool): handle more simulated scenarios in test_utils/pool.rs #20138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattsse merged 13 commits into from
Dec 10, 2025
Merged

feat(txpool): handle more simulated scenarios in test_utils/pool.rs #20138

mattsse merged 13 commits into from
Dec 10, 2025

Conversation

@figtracer
Copy link
Contributor

@figtracer figtracer commented Dec 5, 2025 •
edited
Loading

  • implements ScenarioType::HigherNonce with unit test
  • implements ScenarioType::BelowBaseFee with unit test
  • previously MockPool::default() created a pool with pending_basefee = MIN_PROTOCOL_BASE_FEE and it wasn't matching the simulation's base_fee so also added create_pool() to align simulation's base_fee with pool's pending_basefee.
  • implements ScenarioType::FillNonceGap with unit test
  • previously we weren't using the generated sender, now we use sender in with_sender

@github-project-automation github-project-automation bot moved this to Backlog in Reth Tracker Dec 5, 2025
@figtracer
Copy link
Contributor Author

figtracer commented Dec 5, 2025

@mattsse this is still missing dynamic promotion tests, following previous state, but i think the foundation should be working

the goal now is to use tracked state to trigger promotions programatically

wdyt

mattsse
mattsse approved these changes Dec 6, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, yep, this lgtm

@github-project-automation github-project-automation bot moved this from Backlog to In Progress in Reth Tracker Dec 6, 2025
@mattsse mattsse added the A-tx-pool Related to the transaction mempool label Dec 6, 2025
@figtracer figtracer marked this pull request as ready for review December 8, 2025 13:32
@figtracer figtracer requested a review from yongkangc as a code owner December 8, 2025 13:32
@figtracer
Copy link
Contributor Author

figtracer commented Dec 8, 2025

we should handle these better in the future but i think its a good improvement for now

PoolErrorKind::SpammerExceededCapacity(_) |
PoolErrorKind::ReplacementUnderpriced => return,

mattsse
mattsse approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@mattsse mattsse added this pull request to the merge queue Dec 10, 2025
Merged via the queue into paradigmxyz:main with commit 8c361c8 Dec 10, 2025
43 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Reth Tracker Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsse mattsse mattsse approved these changes

@yongkangc yongkangc Awaiting requested review from yongkangc yongkangc is a code owner

Assignees

No one assigned

Labels

A-tx-pool Related to the transaction mempool

Projects

Reth Tracker
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@figtracer @mattsse