ci: run amd64 and arm64 docker builds in parallel #20194
Closed
+160
−177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Docker build workflows (docker.yml and docker-nightly.yml) to parallelize cross-architecture builds, reducing total build time from ~40 minutes (sequential) to ~20 minutes (parallel). The changes split the build process into two jobs: build-binaries (which builds all arch/variant combinations in parallel using a matrix strategy) and docker-push (which assembles and pushes multi-arch images).
Key changes:
- Split Docker workflows into separate binary building and image pushing stages
- Introduce matrix-based parallel builds for amd64/arm64 architectures across reth/op-reth variants
- Use GitHub Actions artifacts to transfer built binaries between jobs
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/docker.yml |
Refactored to use parallel matrix builds for amd64/arm64 with separate build-binaries and docker-push jobs; consolidated RC and latest image logic into a single conditional push |
.github/workflows/docker-nightly.yml |
Refactored to use parallel matrix builds for amd64/arm64 across maxperf/profiling profiles for both reth and op-reth variants |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0b648f4 to
494d9ce
Compare
494d9ce to
f7d50b5
Compare
yongkangc
approved these changes
Dec 8, 2025
mattsse
approved these changes
Dec 8, 2025
mediocregopher
approved these changes
Dec 9, 2025
Collaborator
Author
|
Should use depot instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building a cross-arch Docker image was done sequentially, meaning that we first wait ~20 minutes for amd64, and then another ~20 minutes for arm64
reth/Makefile
Lines 348 to 364 in 2f55b1c
This PR refactors the
docker.ymlanddocker-nightly.ymlworkflows to run themaxperf/profiling X reth/op-reth X amd64/arm64matrix in parallel.