gh-99892: test_unicodedata: skip test on download failure#100011
gh-99892: test_unicodedata: skip test on download failure#100011vstinner merged 1 commit intopython:mainfrom vstinner:test_unicodedata
Conversation
Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
Sorry @vstinner, I had trouble checking out the |
…onGH-100011) Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net. (cherry picked from commit 2488c1e) Co-authored-by: Victor Stinner <vstinner@python.org>
|
GH-100012 is a backport of this pull request to the 3.10 branch. |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
|
GH-100013 is a backport of this pull request to the 3.11 branch. |
…onGH-100011) Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net. (cherry picked from commit 2488c1e) Co-authored-by: Victor Stinner <vstinner@python.org>
|
Why not add retries to the fetch? I'm afraid this will silently disable the test forever if fetching the file becomes a permanent error. |
|
Hi @benjaminp,
My reason: I want to limit time spent on this issue :-) I only worked on it because I'm getting 1 to 5 emails per day related to test_unicodedata failures, but only on some workers which have other network issues. If someone else is volunteer to enhance the code, please go ahead ;-) A generic function "download a file from the Internet, retry on error, and skip the test after a timeout" sounds like an useful feature ;-) |
|
I very much understand not wanting to spend time. But, as I said, I'm afraid this could have scary side-effects. |
Skip test_normalization() of test_unicodedata if it fails to download NormalizationTest.txt file from pythontest.net.