Skip to content

gh-101538: Add experimental wasi-threads build#101537

Merged
brettcannon merged 9 commits intopython:mainfrom
yamt:wasi-threads
Jun 22, 2023
Merged

gh-101538: Add experimental wasi-threads build#101537
brettcannon merged 9 commits intopython:mainfrom
yamt:wasi-threads

Conversation

@yamt
Copy link
Contributor

@yamt yamt commented Feb 3, 2023 •
edited
Loading

eg.

export WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc
./Tools/wasm/wasm_build.py wasi-threads build
~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py

  • I used an unreleased version of wasi-sdk

  • I used toywasm to test because wasmtime doesn't have
    necessary functionality yet.

@bedevere-bot
Copy link

bedevere-bot commented Feb 3, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@ghost
Copy link

ghost commented Feb 3, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

bedevere-bot commented Feb 3, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev arhadthedev added interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-wasi labels Feb 3, 2023
@arhadthedev
Copy link
Member

arhadthedev commented Feb 3, 2023

Would you mind adding the news entry as the bot suggests? Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

@bedevere-bot
Copy link

bedevere-bot commented Feb 3, 2023

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@yamt yamt changed the title Add experimental wasi-threads build gh-101538: Add experimental wasi-threads build Feb 3, 2023
@bedevere-bot bedevere-bot mentioned this pull request Feb 3, 2023
Closed
@yamt
pythongh-101538: Add experimental wasi-threads build
0ef8b66 
eg.
```
autoconf
export WASI_SDK_PATH=/opt/wasi-sdk-19.5g0236e959edbc
./Tools/wasm/wasm_build.py wasi-threads build
~/git/toywasm/b.thread/toywasm --wasi --wasi-dir . --wasi-dir ~/git/garbage/py/th2 -- builddir/wasi-threads/python.wasm ~/git/garbage/py/th2/thread.py
```

* I used an unreleased version of wasi-sdk

* I used toywasm to test because wasmtime doesn't have
  necessary functionality yet.
@yamt
Copy link
Contributor Author

yamt commented Feb 3, 2023

Would you mind adding the news entry as the bot suggests? Add experimental wasi-threads support. Patch by Takashi Yamamoto. is sufficient.

thank you. done.

@yamt
Regen configure
c4543e1 
```
docker run --rm -v $(pwd):/src quay.io/tiran/cpython_autoconf:269
```
@arhadthedev
Copy link
Member

arhadthedev commented Feb 3, 2023

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

@yamt
Copy link
Contributor Author

yamt commented Feb 3, 2023

No need to rebase and force-push; everything will be squashed into a single commit while merging anyway.

ok. i was not aware of the policy. thank you.

@yamt yamt mentioned this pull request Feb 3, 2023
Open
@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 4, 2023

ok. i was not aware of the policy. thank you.

It is documented in the devguide: https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

erlend-aasland
erlend-aasland reviewed Feb 4, 2023
View reviewed changes
@yamt
Copy link
Contributor Author

yamt commented Feb 6, 2023

ok. i was not aware of the policy. thank you.

It is documented in the devguide: https://devguide.python.org/getting-started/pull-request-lifecycle/#submitting

ok. i was aware of the doc. but apparently i haven't read it carefully enough. thank you for pointing out.

@brettcannon
Copy link
Member

brettcannon commented Feb 10, 2023

As I rejected the feature request I am also unfortunately rejecting this PR.

@brettcannon
Copy link
Member

brettcannon commented Apr 5, 2023

FYI in case this PR gets re-opened (instead of a new one) when WASI threads goes stable, I was able to build with WASI SDK 20 and this PR.

@brettcannon brettcannon reopened this Jun 12, 2023
@brettcannon
Copy link
Member

brettcannon commented Jun 12, 2023

@yamt I got tacit approval to turn this on as long as it is clearly marked as experimental. Did you want to refresh this PR as necessary?

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 14, 2023

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

@yamt
Copy link
Contributor Author

yamt commented Jun 21, 2023

@yamt, I marked our Autoconf conversation as resolved and also took the liberty to apply a small Autoconf style change. Hope you don't mind.

thank you.

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Jun 22, 2023 •
edited
Loading

AFAICS, we can land this now, @brettcannon. I'll wait a couple of days to give you a chance to look over it before merging :)

@brettcannon
Copy link
Member

brettcannon commented Jun 22, 2023

It's experimental (and even undocumented ATM 😅), so I'm good with it.

@brettcannon brettcannon merged commit d8f87cd into python:main Jun 22, 2023
@brettcannon
Copy link
Member

brettcannon commented Jun 22, 2023

@yamt Thanks! I will update https://github.com/brettcannon/cpython-wasi-build probably in the next week or so to start producing a threaded build for WASI on top of the "normal" build w/o threads.

bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@yamt @brettcannon
@erlend-aasland @bentasker
pythongh-101538: Add experimental wasi-threads build (python#101537)
2df334b 
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@brettcannon
Copy link
Member

brettcannon commented Jul 12, 2023

@Yhg1s is it okay to backport this to 3.12?

@Yhg1s
Copy link
Member

Yhg1s commented Jul 17, 2023

Yes, this is fine for 3.12 (if it gets into RC1, scheduled for 2 weeks from now).

@erlend-aasland erlend-aasland added the needs backport to 3.12 only security fixes label Jul 17, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Jul 17, 2023

Thanks @yamt for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jul 17, 2023

GH-106834 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 17, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2023
@yamt @brettcannon
@erlend-aasland @miss-islington
pythongh-101538: Add experimental wasi-threads build (pythonGH-101537)
b97d216 
(cherry picked from commit d8f87cd)

Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jul 17, 2023
@miss-islington @yamt
@brettcannon @erlend-aasland
[3.12] gh-101538: Add experimental wasi-threads build (GH-101537) (#1…
e903c16 
…06834)

(cherry picked from commit d8f87cd)

Co-authored-by: YAMAMOTO Takashi <yamamoto@midokura.com>
Co-authored-by: Brett Cannon <brett@python.org>
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) OS-wasi

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@yamt @bedevere-bot @arhadthedev @erlend-aasland @brettcannon @Yhg1s @miss-islington