Skip to content

gh-101334: Don't force USTAR format in test_tarfile.#101572

Merged
ethanfurman merged 5 commits intopython:mainfrom
gpshead:test_tarfile_high_uid
Feb 5, 2023
Merged

gh-101334: Don't force USTAR format in test_tarfile.#101572
ethanfurman merged 5 commits intopython:mainfrom
gpshead:test_tarfile_high_uid

Conversation

@gpshead
Copy link
Member

@gpshead gpshead commented Feb 5, 2023 •
edited by bedevere-bot
Loading

That causes the test to fail when run using a high UID as that ancient format cannot represent it. The current default (PAX) and the old default (GNU) both support high UIDs.

@gpshead
pythongh-101334: Don't force USTAR format in test_tarfile.
2597aad 
That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
@bedevere-bot bedevere-bot mentioned this pull request Feb 5, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Feb 5, 2023
@gpshead
Copy link
Member Author

gpshead commented Feb 5, 2023

!buildbot aarch64 Debian Clang

@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 2597aad 🤖

The command will test the builders whose names match following regular expression: aarch64 Debian Clang

The builders matched are:

@gpshead
Copy link
Member Author

gpshead commented Feb 5, 2023

!buildbot aarch64 Debian.*

@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 2597aad 🤖

The command will test the builders whose names match following regular expression: aarch64 Debian.*

The builders matched are:

@gpshead
Copy link
Member Author

gpshead commented Feb 5, 2023

!buildbot aarch64

@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

🤖 New build scheduled with the buildbot fleet by @gpshead for commit 2597aad 🤖

The command will test the builders whose names match following regular expression: aarch64

The builders matched are:

  • aarch64 Fedora Stable LTO + PGO PR
  • aarch64 Fedora Stable Refleaks PR
  • aarch64 Fedora Stable LTO PR
  • aarch64 RHEL8 LTO PR
  • aarch64 Fedora Stable PR
  • aarch64 RHEL8 PR
  • aarch64 RHEL8 Refleaks PR
  • aarch64 RHEL8 LTO + PGO PR
  • aarch64 Fedora Stable Clang PR
  • aarch64 Fedora Stable Clang Installed PR

@gpshead gpshead added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 5, 2023
@gpshead gpshead marked this pull request as ready for review February 5, 2023 08:29
@gpshead gpshead requested a review from ethanfurman as a code owner February 5, 2023 08:29
@ethanfurman ethanfurman merged commit ffcb822 into python:main Feb 5, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Feb 5, 2023

Thanks @gpshead for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Feb 5, 2023

Sorry @gpshead and @ethanfurman, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker ffcb8220d7a8c8ca169b467d9e4a752874f68af2 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2023
@gpshead @miss-islington
pythongh-101334: Don't force USTAR format in test_tarfile. (pythonGH-…
bd04a50 
…101572)

That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
(cherry picked from commit ffcb822)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

GH-101583 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 5, 2023
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Feb 5, 2023
@miss-islington
Copy link
Contributor

miss-islington commented Feb 5, 2023

Thanks @gpshead for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

GH-101584 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2023
@gpshead @miss-islington
pythongh-101334: Don't force USTAR format in test_tarfile. (pythonGH-…
b224858 
…101572)

That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
(cherry picked from commit ffcb822)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@gpshead gpshead deleted the test_tarfile_high_uid branch February 5, 2023 19:44
miss-islington added a commit that referenced this pull request Feb 5, 2023
@miss-islington @gpshead
gh-101334: Don't force USTAR format in test_tarfile. (GH-101572)
435fcb0 
That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
(cherry picked from commit ffcb822)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
miss-islington added a commit that referenced this pull request Feb 5, 2023
@miss-islington @gpshead
gh-101334: Don't force USTAR format in test_tarfile. (GH-101572)
6ae8032 
That causes the test to fail when run using a high UID as that ancient format
cannot represent it. The current default (PAX) and the old default (GNU) both
support high UIDs.
(cherry picked from commit ffcb822)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

bedevere-bot commented Feb 5, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 3.11 has failed when building commit 6ae8032.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1033/builds/665) and take a look at the build logs.
  4. Check if the failure is related to this commit (6ae8032) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1033/builds/665

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

413 tests OK.

10 slowest tests:

  • test_tools: 3 min 5 sec
  • test_concurrent_futures: 2 min 31 sec
  • test_multiprocessing_spawn: 1 min 56 sec
  • test_asyncio: 1 min 26 sec
  • test_multiprocessing_forkserver: 1 min 24 sec
  • test_subprocess: 1 min 14 sec
  • test_multiprocessing_fork: 1 min 12 sec
  • test_tokenize: 1 min 1 sec
  • test_capi: 1 min
  • test_compileall: 51.3 sec

1 test altered the execution environment:
test_asyncio

20 tests skipped:
test_devpoll test_gdb test_idle test_ioctl test_kqueue
test_launcher test_msilib test_smtpnet test_ssl test_startfile
test_tcl test_tix test_tk test_ttk_guionly test_ttk_textonly
test_turtle test_winconsoleio test_winreg test_winsound
test_zipfile64

Total duration: 6 min 23 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_6a73550e'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_ff6f7e15'


Traceback (most recent call last):
  File "/home/dje/cpython-buildarea/3.11.edelsohn-rhel-z/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_0020283c'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@CuriousLearner CuriousLearner CuriousLearner approved these changes

Assignees

@ethanfurman ethanfurman

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gpshead @bedevere-bot @miss-islington @ethanfurman @CuriousLearner @AlexWaygood