gh-69990: Make Profile.print_stats support sorting by multiple values by furkanonder · Pull Request #104590 · python/cpython

furkanonder · 2023-05-17T21:31:19Z

Issue: Make Profile.print_stats support sorting by mutiple values #69990

serhiy-storchaka

Please update the modules documentation.

bedevere-app · 2024-01-17T13:20:27Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

serhiy-storchaka · 2024-02-01T20:02:59Z

Doc/library/profile.rst

+      to enable multi-level sorting.
+
+      .. versionadded:: 3.13
+         :meth:`~Profile.print_stats` can now accept multiple sort arguments.


"can accept multiple sort arguments" looks confusing. Does print_stats('calls', 'time') or print_stats(sort='calls', sort='time') work?

Example:

import cProfile from pstats import SortKey with cProfile.Profile() as pr: pr.print_stats(sort=("time", "calls")) # or pr.print_stats(sort=(SortKey.TIME, SortKey.CALLS))

I believe that adding a small example to the documentation would make it easier to understand the feature. What do you think?

Lib/test/test_profile.py

Lib/profile.py

Doc/library/profile.rst

Co-authored-by: Ege Akman <egeakmanegeakman@hotmail.com>

Doc/library/profile.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Doc/library/profile.rst

Co-authored-by: Ege Akman <egeakmanegeakman@hotmail.com>

Doc/library/profile.rst

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

Doc/library/profile.rst

bedevere-bot · 2024-02-16T12:09:42Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Bigmem 3.x has failed when building commit 2a7a002.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1079/builds/3417) and take a look at the build logs.
Check if the failure is related to this commit (2a7a002) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1079/builds/3417

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 15, done.        
remote: Counting objects:   7% (1/14)        
remote: Counting objects:  14% (2/14)        
remote: Counting objects:  21% (3/14)        
remote: Counting objects:  28% (4/14)        
remote: Counting objects:  35% (5/14)        
remote: Counting objects:  42% (6/14)        
remote: Counting objects:  50% (7/14)        
remote: Counting objects:  57% (8/14)        
remote: Counting objects:  64% (9/14)        
remote: Counting objects:  71% (10/14)        
remote: Counting objects:  78% (11/14)        
remote: Counting objects:  85% (12/14)        
remote: Counting objects:  92% (13/14)        
remote: Counting objects: 100% (14/14)        
remote: Counting objects: 100% (14/14), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 15 (delta 2), reused 4 (delta 2), pack-reused 1        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '2a7a0020c9d006d268b839320979364498a5f0e6'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 2a7a0020c9 gh-69990: Make Profile.print_stats support sorting by multiple values (GH-104590)
Switched to and reset branch 'main'

Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\Lib\*.pyc
The system cannot find the file specified.
Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\PCbuild\python*.zip

Cannot open file 'R:\buildarea\3.x.ambv-bb-win11.bigmem\build\test-results.xml' for upload

The system cannot find the file specified.
Could Not Find R:\buildarea\3.x.ambv-bb-win11.bigmem\build\PCbuild\python*.zip

ambv · 2024-02-16T12:09:52Z

The failure is unrelated, being fixed in #115557

…values (pythonGH-104590) Co-authored-by: Chiu-Hsiang Hsu

Make Profile.print_stats support sorting by mutiple values

212b668

bedevere-bot added the awaiting review label May 17, 2023

bedevere-bot mentioned this pull request May 17, 2023

Make Profile.print_stats support sorting by mutiple values #69990

Closed

furkanonder changed the title ~~gh-69990: Make Profile.print_stats support sorting by mutiple values~~ gh-69990: Make Profile.print_stats support sorting by multiple values May 17, 2023

blurb-it bot and others added 3 commits May 17, 2023 21:33

📜🤖 Added by blurb_it.

da1b596

Merge branch 'main' into issue-69990

1ac24af

Merge branch 'main' into issue-69990

9f18231

furkanonder added stdlib Standard Library Python modules in the Lib/ directory type-feature A feature request or enhancement labels Aug 6, 2023

serhiy-storchaka requested changes Jan 17, 2024

View reviewed changes

bedevere-app bot removed the awaiting review label Jan 17, 2024

bedevere-app bot added the awaiting changes label Jan 17, 2024

furkanonder added the 3.13 bugs and security fixes label Jan 28, 2024

furkanonder added 6 commits January 29, 2024 02:55

update documentation according to the new feature

f771358

fix code format

1d8c4e4

update the news entry

82facb0

fix code format

80bb65b

update documentation according to the new feature

0253706

update the news entry

58c7e35

serhiy-storchaka reviewed Feb 1, 2024

View reviewed changes

furkanonder added 6 commits February 10, 2024 13:23

fix merge conflict

1905e3f

use contextlib's redirect_stdout

fb4b8cb

use isinstance check for the sorting tuple

66e1e82

update documentation of print_stats method

dfa668d

remove whitespace

96b1bdd

Merge branch 'main' into issue-69990

e1a70e0

furkanonder requested a review from serhiy-storchaka February 10, 2024 12:19

egeakman reviewed Feb 10, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

egeakman reviewed Feb 10, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

furkanonder and others added 3 commits February 10, 2024 17:47

Update Doc/library/profile.rst

f6b235f

Co-authored-by: Ege Akman <egeakmanegeakman@hotmail.com>

Update Doc/library/profile.rst

bb0507b

Co-authored-by: Ege Akman <egeakmanegeakman@hotmail.com>

Merge branch 'main' into issue-69990

4cccb55

serhiy-storchaka reviewed Feb 10, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

Doc/library/profile.rst Outdated Show resolved Hide resolved

fix the syntax of the documentation grammar in print_stats

b083716

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

egeakman reviewed Feb 10, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

clarify valid key types in print_stats method

7fdbfab

Co-authored-by: Ege Akman <egeakmanegeakman@hotmail.com>

serhiy-storchaka reviewed Feb 12, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

Doc/library/profile.rst Outdated Show resolved Hide resolved

furkanonder and others added 2 commits February 13, 2024 23:26

clarify valid key types in print_stats method

49ca018

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

update versionadded section

4ea5e4c

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>

serhiy-storchaka approved these changes Feb 16, 2024

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting changes labels Feb 16, 2024

serhiy-storchaka reviewed Feb 16, 2024

View reviewed changes

Doc/library/profile.rst Outdated Show resolved Hide resolved

Update Doc/library/profile.rst

9978802

serhiy-storchaka enabled auto-merge (squash) February 16, 2024 11:50

serhiy-storchaka merged commit 2a7a002 into python:main Feb 16, 2024

bedevere-app bot removed the awaiting merge label Feb 16, 2024

woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024

pythongh-69990: Make Profile.print_stats support sorting by multiple …

5261d53

…values (pythonGH-104590) Co-authored-by: Chiu-Hsiang Hsu

diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024

pythongh-69990: Make Profile.print_stats support sorting by multiple …

1db6106

…values (pythonGH-104590) Co-authored-by: Chiu-Hsiang Hsu

furkanonder removed the 3.13 bugs and security fixes label Dec 31, 2024

LukasWoodtli pushed a commit to LukasWoodtli/cpython that referenced this pull request Jan 22, 2025

pythongh-69990: Make Profile.print_stats support sorting by multiple …

cb1f06a

…values (pythonGH-104590) Co-authored-by: Chiu-Hsiang Hsu

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

gh-69990: Make Profile.print_stats support sorting by multiple values#104590

gh-69990: Make Profile.print_stats support sorting by multiple values#104590
serhiy-storchaka merged 24 commits intopython:mainfrom
furkanonder:issue-69990

furkanonder commented May 17, 2023 •

edited by bedevere-bot

Loading

Uh oh!

serhiy-storchaka left a comment

Uh oh!

bedevere-app bot commented Jan 17, 2024

Uh oh!

serhiy-storchaka Feb 1, 2024

Uh oh!

furkanonder Feb 10, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Feb 16, 2024

Uh oh!

ambv commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

furkanonder commented May 17, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app bot commented Jan 17, 2024

Uh oh!

serhiy-storchaka Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

furkanonder Feb 10, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Feb 16, 2024

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

ambv commented Feb 16, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

furkanonder commented May 17, 2023 •

edited by bedevere-bot

Loading