gh-110733: Optimize _run_once for many iterations of the event loop#110735
Merged
gvanrossum merged 3 commits intopython:mainfrom Oct 11, 2023
Merged
gh-110733: Optimize _run_once for many iterations of the event loop#110735gvanrossum merged 3 commits intopython:mainfrom
gvanrossum merged 3 commits intopython:mainfrom
Conversation
gvanrossum
approved these changes
Oct 11, 2023
Member
gvanrossum
left a comment
There was a problem hiding this comment.
The patch LGTM. I haven't confirmed the speedup but I agree that not calling min() or max() is slightly faster. It will matter even more in 3.13 when we expect to have a basic tracing JIT.
I noticed that you considered calling time() only once -- do you want to add that to the PR? Or did you already measure it and it doesn't help?
Misc/NEWS.d/next/Library/2023-10-11-18-43-43.gh-issue-110733.UlrgVm.rst
Outdated
Show resolved
Hide resolved
Contributor
Author
I couldn't come up with a way to get it to work that wasn't a breaking change since we need the time before the |
Contributor
Author
|
Thanks! |
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
minandmaxin_run_oncewith simple<and>close #110733
benchmarks in #110733