gh-112139: Add inspect.Signature.format and use it in pydoc#112143
Merged
JelleZijlstra merged 7 commits intopython:mainfrom Dec 2, 2023
Merged
gh-112139: Add inspect.Signature.format and use it in pydoc#112143JelleZijlstra merged 7 commits intopython:mainfrom
inspect.Signature.format and use it in pydoc#112143JelleZijlstra merged 7 commits intopython:mainfrom
Conversation
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thanks, it's great this is relatively simple to implement.
Should we make this a public, supported feature of inspect.signature? It may be useful for users other than pydoc. For example, we could add a __format__. Then perhaps something like f"{sig:78p}" could be used.
Member
Author
|
Yes, I think we should add a new method called |
pretty to inspect.Signature and use it in pydocinspect.Signature.format and use it in pydoc
Member
JelleZijlstra
left a comment
There was a problem hiding this comment.
Thank you! Sorry I forgot about reviewing this PR.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
JelleZijlstra
approved these changes
Dec 2, 2023
Member
|
Wow, this is going to be a big quality-of-life improvement. Thanks @sobolevn and @JelleZijlstra! :D |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…python#112143) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…python#112143) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do you think about
__str__with a parameter? Or should we add an alias for this, likedef to_string(self, *, pretty)?