gh-112243: Don't include comments in f-string debug expressions#112284
Merged
pablogsal merged 2 commits intopython:mainfrom Nov 20, 2023
Merged
gh-112243: Don't include comments in f-string debug expressions#112284pablogsal merged 2 commits intopython:mainfrom
pablogsal merged 2 commits intopython:mainfrom
Conversation
lysnikolaou
reviewed
Nov 20, 2023
Member
lysnikolaou
left a comment
There was a problem hiding this comment.
Left a couple of comments. Also, the lint job fails.
Member
Author
|
@lysnikolaou fixed! |
|
GH-112285 is a backport of this pull request to the 3.12 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Nov 20, 2023
…essions (pythonGH-112284) (cherry picked from commit d59feb5) Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal
added a commit
that referenced
this pull request
Nov 20, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.