gh-114909: Add --first-weekday option to usage message#114910
Merged
hugovk merged 1 commit intopython:mainfrom Feb 2, 2024
planet36:gh-114909
Merged
gh-114909: Add --first-weekday option to usage message#114910hugovk merged 1 commit intopython:mainfrom planet36:gh-114909
hugovk merged 1 commit intopython:mainfrom
planet36:gh-114909
Conversation
Use FIRST_WEEKDAY rather than WEEKDAY to be in agreement with the command line help message. Note which Python version the option was added to.
hugovk
reviewed
Feb 2, 2024
| Must be a number between 0 (Monday) and 6 (Sunday). | ||
| Defaults to 0. | ||
|
|
||
| .. versionadded:: 3.13 |
Member
There was a problem hiding this comment.
@erlend-aasland We talked recently about the distinction between versionadded and versionchanged, which do you think we should have here?
https://devguide.python.org/documentation/markup/#paragraph-level-markup
Member
There was a problem hiding this comment.
If it is applied to the option -- versionadded. If to the whole CLI -- versionchanged.
Contributor
There was a problem hiding this comment.
Yes, this looks correct to me.
serhiy-storchaka
approved these changes
Feb 2, 2024
| Must be a number between 0 (Monday) and 6 (Sunday). | ||
| Defaults to 0. | ||
|
|
||
| .. versionadded:: 3.13 |
Member
There was a problem hiding this comment.
If it is applied to the option -- versionadded. If to the whole CLI -- versionchanged.
erlend-aasland
approved these changes
Feb 2, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
fsc-eriker
pushed a commit
to fsc-eriker/cpython
that referenced
this pull request
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
FIRST_WEEKDAYrather thanWEEKDAYto be in agreement with the command line help message.Note which Python version the option was added to.
📚 Documentation preview 📚: https://cpython-previews--114910.org.readthedocs.build/