gh-121889: cmath.acosh(0+nanj) returns nan+pi/2j#121892
Merged
mdickinson merged 1 commit intopython:mainfrom Aug 4, 2024
Merged
gh-121889: cmath.acosh(0+nanj) returns nan+pi/2j#121892mdickinson merged 1 commit intopython:mainfrom
mdickinson merged 1 commit intopython:mainfrom
Conversation
As per C11 DR#471 (adjusted resolution accepted for C17), cacosh (0 + iNaN) should return NaN ± i pi/2, not NaN + iNaN. This patch fixes cmath's code to do same.
mdickinson
approved these changes
Aug 4, 2024
Member
mdickinson
left a comment
There was a problem hiding this comment.
Thanks for the PR. This LGTM.
I don't think this should be backported - it's not behaviour that I'd want to change in a bugfix release. It's enough that CPython will eventually (Python >= 3.14) do the right thing.
brandtbucher
pushed a commit
to brandtbucher/cpython
that referenced
this pull request
Aug 7, 2024
As per C11 DR#471 (adjusted resolution accepted for C17), cacosh (0 + iNaN) should return NaN ± i pi/2, not NaN + iNaN. This patch fixes cmath's code to do same.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
As per C11 DR#471 (adjusted resolution accepted for C17), cacosh (0 + iNaN) should return NaN ± i pi/2, not NaN + iNaN. This patch fixes cmath's code to do same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per C11 DR#471 (adjusted resolution accepted for C17), cacosh (0 + iNaN) should return NaN ± i pi/2, not NaN + iNaN. This patch fixes cmath's code to do same.
glibc patch: https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=5244527da1bfa751492e146d3e6ae128c59bfcc4