GH-124483: Treat _Py_Dealloc as an escaping call in tier two#124615
Closed
brandtbucher wants to merge 6 commits intopython:mainfrom
Closed
GH-124483: Treat _Py_Dealloc as an escaping call in tier two#124615brandtbucher wants to merge 6 commits intopython:mainfrom
_Py_Dealloc as an escaping call in tier two#124615brandtbucher wants to merge 6 commits intopython:mainfrom
Conversation
Member
|
I thought Mark was planning to fix this by deferring |
Member
Author
We may at some point, but this will keep things safe until then. We may also not defer all decrefs, depending on how disruptive it is to do so. In any case, I'll wait until after #124392 is merged to pick this up and re-run the benchmarks, since this will introduce a lot of new spills. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes various issues related to finalizers "invalidating the world".
Despite the fact that it executes about 29 billion additional
_CHECK_VALIDITY,_SET_IP, and_CHECK_VALIDITY_AND_SET_IPinstructions on the benchmarks, these are some of our cheapest uops, so performance and memory are both unaffected._Py_Deallocis an escaping call #124483