Skip to content

add missing gc_collect() calls in sqlite3 tests#127446

Merged
cfbolz merged 1 commit intopython:mainfrom
cfbolz:sqlite3-test-regression-missing-gc-collect
Dec 2, 2024
Merged

add missing gc_collect() calls in sqlite3 tests#127446
cfbolz merged 1 commit intopython:mainfrom
cfbolz:sqlite3-test-regression-missing-gc-collect

Conversation

@cfbolz
Copy link
Contributor

@cfbolz cfbolz commented Nov 30, 2024

PyPy needs a gc_collect() call after the del cur statements for the cursors' finalizers to execute.

@cfbolz cfbolz added tests Tests in the Lib/test dir skip issue skip news labels Nov 30, 2024
@ZeroIntensity ZeroIntensity added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Nov 30, 2024
erlend-aasland
erlend-aasland approved these changes Nov 30, 2024
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PyPy needs a gc_collect() call after the del cur statements for the cursors' finalizers to execute.

Thanks. I wonder if we should add a short "needed-for-pypy-comment" behind the gc_collect() calls.

@cfbolz
Copy link
Contributor Author

cfbolz commented Dec 1, 2024

I wonder if we should add a short "needed-for-pypy-comment" behind the gc_collect() calls.

It's also needed for all other Python implementations that don't use reference counting (GraalPy, for example). Also CPython is moving in the general direction of having less timely finalization (e.g. with deferred refcounting). So I don't think a comment that this is only for pypy is that helpful.

@cfbolz cfbolz merged commit 2a373da into python:main Dec 2, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 2, 2024

Thanks @cfbolz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
@cfbolz @miss-islington
add missing gc_collect() calls in sqlite3 tests (pythonGH-127446)
0596ad4 
(cherry picked from commit 2a373da)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127500 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 2, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 2, 2024
@cfbolz @miss-islington
add missing gc_collect() calls in sqlite3 tests (pythonGH-127446)
8baa8ee 
(cherry picked from commit 2a373da)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
@bedevere-app
Copy link

bedevere-app bot commented Dec 2, 2024

GH-127501 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Dec 2, 2024
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @cfbolz
[3.12] add missing gc_collect() calls in sqlite3 tests (GH-127446) (#…
97fd09f 
…127501)

add missing gc_collect() calls in sqlite3 tests (GH-127446)
(cherry picked from commit 2a373da)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
Yhg1s pushed a commit that referenced this pull request Dec 2, 2024
@miss-islington @cfbolz
[3.13] add missing gc_collect() calls in sqlite3 tests (GH-127446) (#…
511c588 
…127500)

add missing gc_collect() calls in sqlite3 tests (GH-127446)
(cherry picked from commit 2a373da)

Co-authored-by: CF Bolz-Tereick <cfbolz@gmx.de>
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Jan 8, 2025
@cfbolz @srinivasreddy
add missing gc_collect() calls in sqlite3 tests (python#127446)
43ceb14
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@cfbolz @ebonnal
add missing gc_collect() calls in sqlite3 tests (python#127446)
0ff4f9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cfbolz @serhiy-storchaka @erlend-aasland @ZeroIntensity