gh-130673: Gracefully handle section in jit build#130906
gh-130673: Gracefully handle section in jit build#130906brandtbucher merged 3 commits intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Thanks for doing this! Did you confirm that this fixes your build?
Per the bot, please add a blurb entry to the Build section. No need to force-push either; it just makes reviewing more difficult, and everything is squashed at the end anyway. You might want to look at the devguide for some advice on PRs.
Yeah, I've tested on 3.13.2 and main branch. It just works.
Thanks for your remind! This is my first time opening PR for CPython and thanks for your review! |
brandtbucher
left a comment
There was a problem hiding this comment.
Looks great, thanks. Mind adding a comment explaining why we're returning early here?
|
Does this CI failure matter? |
|
Thanks @rennsax for the PR, and @brandtbucher for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
…honGH-130906) (cherry picked from commit a26a301) Co-authored-by: Bojun Ren <bj.ren.coding@outlook.com>
|
GH-131749 is a backport of this pull request to the 3.13 branch. |
Fix #130673