Skip to content

gh-85702: Catch IsADirectoryError in zoneinfo#131333

Merged
vstinner merged 6 commits intopython:mainfrom
StanFromIreland:zoneinfo-error
Apr 14, 2025
Merged

gh-85702: Catch IsADirectoryError in zoneinfo#131333
vstinner merged 6 commits intopython:mainfrom
StanFromIreland:zoneinfo-error

Conversation

@StanFromIreland
Copy link
Member

@StanFromIreland StanFromIreland commented Mar 16, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 16, 2025
Closed
@StanFromIreland
Copy link
Member Author

StanFromIreland commented Mar 16, 2025

Requesting @vstinner

I did not cover PermissionsError as you were not a fan of the idea (and neither am I) and I also can't test on windows. So I presumed its best to just stick to the title of the issue :-)

vstinner
vstinner reviewed Mar 17, 2025
View reviewed changes
@StanFromIreland @vstinner
Update Lib/test/test_zoneinfo/test_zoneinfo.py
99731e8 
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
vstinner approved these changes Mar 17, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StanFromIreland
Copy link
Member Author

StanFromIreland commented Apr 14, 2025

Anything else I should do @vstinner

@vstinner vstinner enabled auto-merge (squash) April 14, 2025 17:04
@vstinner
Copy link
Member

vstinner commented Apr 14, 2025

I enabled auto-merge on this PR.

@vstinner vstinner merged commit d22604a into python:main Apr 14, 2025
39 checks passed
@StanFromIreland StanFromIreland deleted the zoneinfo-error branch April 14, 2025 17:08
@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Jun 30, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 30, 2025

Thanks @StanFromIreland for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2025
@StanFromIreland @vstinner @miss-islington
pythongh-85702: Catch IsADirectoryError in zoneinfo (pythonGH-131333)
ca3f395 
(cherry picked from commit d22604a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Jun 30, 2025

GH-136130 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 30, 2025
vstinner added a commit that referenced this pull request Jun 30, 2025
@miss-islington @StanFromIreland @vstinner
[3.13] gh-85702: Catch IsADirectoryError in zoneinfo (GH-131333) (#13…
4f4fa72 
…6130)

gh-85702: Catch IsADirectoryError in zoneinfo (GH-131333)
(cherry picked from commit d22604a)

Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @vstinner