Merged
Conversation
Christian Heimes is now inactive for 2 years.
Member
Author
ezio-melotti
approved these changes
Oct 2, 2025
Member
Author
picnixz
approved these changes
Oct 2, 2025
Member
picnixz
left a comment
There was a problem hiding this comment.
I also think it makes sense to only keep active maintainers in CODEOWNERS.
AA-Turner
approved these changes
Oct 2, 2025
Member
AA-Turner
left a comment
There was a problem hiding this comment.
In general I think we should see CODEOWNERS as 'automatically requested' rather than blocking/required reviews, see this section.
That being said, no objection to keeping the list up-to-date, it can provide the wrong signal to contributors that a review is requested, so they may be more reluctant to ask for updates etc. We can always add people back later, CODEOWNERS should be a fairly light-touch thing.
A
Member
Author
|
Merged. Thanks for reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Christian Heimes is now inactive for 2 years.