Skip to content

gh-75572: Fix test_xpickle and disable it by default#143503

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:fix-test_xpickle
Jan 6, 2026
Merged

gh-75572: Fix test_xpickle and disable it by default#143503
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:fix-test_xpickle

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 6, 2026 •
edited by bedevere-app bot
Loading

@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.14 bugs and security fixes labels Jan 6, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 6, 2026
Closed
@serhiy-storchaka serhiy-storchaka enabled auto-merge (squash) January 6, 2026 22:17
@serhiy-storchaka serhiy-storchaka merged commit b866a1c into python:main Jan 6, 2026
87 of 89 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jan 6, 2026

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2026
@serhiy-storchaka @miss-islington
pythongh-75572: Fix test_xpickle and disable it by default (pythonGH-…
82246aa 
…143503)

(cherry picked from commit b866a1c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jan 6, 2026

GH-143505 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jan 6, 2026
serhiy-storchaka added a commit that referenced this pull request Jan 7, 2026
@miss-islington @serhiy-storchaka
[3.14] gh-75572: Fix test_xpickle and disable it by default (GH-143503)…
ad53bf5 
… (GH-143505)

(cherry picked from commit b866a1c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jan 7, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows11 Refleaks 3.14 (tier-1) has failed when building commit ad53bf5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1682/builds/404) and take a look at the build logs.
  4. Check if the failure is related to this commit (ad53bf5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1682/builds/404

Failed tests:

  • test_external_inspection

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
                     "__main__", mod_spec)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
    ~~~~^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 138, in <module>
    main()
    ~~~~^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 133, in main
    with os_helper.temp_cwd(work_dir, quiet=True):
         ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
         ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 545, in temp_dir
    rmtree(path)
    ~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 497, in rmtree
    _rmtree(path)
    ~~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in _rmtree
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in <lambda>
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
                       ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 219, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_5228�'


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 524, in temp_dir
    os.mkdir(path)
    ~~~~~~~~^^^^^^
FileExistsError: [WinError 183] Cannot create a file when that file already exists: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_6976�'
Stack (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 138, in <module>
    main()
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 133, in main
    with os_helper.temp_cwd(work_dir, quiet=True):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 141, in __enter__
    return next(self.gen)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 208, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_5228�'


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 540, in temp_dir
    yield path
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 599, in temp_cwd
    yield cwd_dir
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 134, in main
    worker_process(worker_json)
    ~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 120, in worker_process
    sys.exit(0)
    ~~~~~~~~^^^
SystemExit: 0


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 208, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_16628�'


Traceback (most recent call last):
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 198, in _run_module_as_main
    return _run_code(code, main_globals, None,
                     "__main__", mod_spec)
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\runpy.py", line 88, in _run_code
    exec(code, run_globals)
    ~~~~^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 138, in <module>
    main()
    ~~~~^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\libregrtest\worker.py", line 133, in main
    with os_helper.temp_cwd(work_dir, quiet=True):
         ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 597, in temp_cwd
    with temp_dir(path=name, quiet=quiet) as temp_path:
         ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\contextlib.py", line 162, in __exit__
    self.gen.throw(value)
    ~~~~~~~~~~~~~~^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 545, in temp_dir
    rmtree(path)
    ~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 497, in rmtree
    _rmtree(path)
    ~~~~~~~^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in _rmtree
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
    ~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 381, in _waitfor
    func(pathname)
    ~~~~^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\os_helper.py", line 441, in <lambda>
    _waitfor(lambda p: _force_run(p, os.rmdir, p), path)
                       ~~~~~~~~~~^^^^^^^^^^^^^^^^
  File "b:\uildarea\3.14.ware-win11.refleak\build\Lib\test\support\__init__.py", line 219, in _force_run
    return func(*args)
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'B:\\uildarea\\3.14.ware-win11.refleak\\build\\build\\test_python_16628�'

thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@serhiy-storchaka @thunder-coding
pythongh-75572: Fix test_xpickle and disable it by default (pythonGH-…
1c076f5 
…143503)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @bedevere-bot