GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime#144740
Conversation
…t compile-time version, not runtime
|
I'm yet to actually test this by the described reproducer. |
It works. |
picnixz
left a comment
There was a problem hiding this comment.
I think SetBillionLaughsAttackProtectionActivationThreshold also suffers from that so the test guarding for expat 2.4 should also be guarded. I don't remember whether 3.13 was the release that included that one or if it was something that was already there for a long time. You can address that in a follow-up PR though.
|
Sorry, @hroncok and @vstinner, I could not cleanly backport this to |
|
Sorry, @hroncok and @vstinner, I could not cleanly backport this to |
…t compile-time version, not runtime (python#144740) (cherry picked from commit 45e9343)
|
GH-145494 is a backport of this pull request to the 3.14 branch. |
|
Merged. Thanks for the fix @hroncok. |
…on expat compile-time version, not runtime (pythonGH-144740) (pythonGH-145494) pythonGH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (pythonGH-144740) (cherry picked from commit 45e9343) (cherry picked from commit bcc2dd8) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Miro Hrončok <miro@hroncok.cz>
…at compile-time version, not runtime (GH-144740) (GH-145494) (#145510) [3.14] GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (GH-144740) (GH-145494) GH-144739: Skip test_pyexpat.MemoryProtectionTest based on expat compile-time version, not runtime (GH-144740) (cherry picked from commit 45e9343) (cherry picked from commit bcc2dd8) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Miro Hrončok <miro@hroncok.cz>
FTR I don't have an environment with epxat that old, so I won't be driving that change. |
test_pyexpat.MemoryProtectionTestfails when Python was built with expat 2.7.1 but runs with 2.7.2 #144739