Skip to content

bpo-39019: Implement missing __class_getitem__ for os.DirEntry #17561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
isidentical wants to merge 2 commits into from
Closed

bpo-39019: Implement missing __class_getitem__ for os.DirEntry #17561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3435737
bpo-39019: Implement missing __class_getitem__ for os.DirEntry
isidentical Dec 10, 2019
4cea396
Update Misc/NEWS.d/next/Library/2019-12-10-21-22-20.bpo-39019.SkVoG0.rst
isidentical Dec 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/test/test_os.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3655,6 +3655,9 @@ def test_unpickable(self):
import pickle
self.assertRaises(TypeError, pickle.dumps, entry, filename)

def test_class_getitem(self):
self.assertIs(os.DirEntry[str], os.DirEntry)


class TestScandir(unittest.TestCase):
check_no_resource_warning = support.check_no_resource_warning
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2019-12-10-21-22-20.bpo-39019.SkVoG0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Implement dummy ``__class_getitem__`` for ``os.DirEntry``.
8 changes: 8 additions & 0 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12791,6 +12791,13 @@ os_DirEntry___fspath___impl(DirEntry *self)
return self->path;
}

static PyObject *
DirEntry_cls_getitem(PyObject *cls, PyObject *type)
{
Py_INCREF(cls);
return cls;
}

static PyMemberDef DirEntry_members[] = {
{"name", T_OBJECT_EX, offsetof(DirEntry, name), READONLY,
"the entry's base filename, relative to scandir() \"path\" argument"},
Expand All @@ -12808,6 +12815,7 @@ static PyMethodDef DirEntry_methods[] = {
OS_DIRENTRY_STAT_METHODDEF
OS_DIRENTRY_INODE_METHODDEF
OS_DIRENTRY___FSPATH___METHODDEF
{"__class_getitem__", DirEntry_cls_getitem, METH_O|METH_CLASS, NULL},
Copy link
Member

@ilevkivskyi ilevkivskyi Dec 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use Argument Clinic for this (to be consistent with the rest of the code in this module)?

Copy link
Member Author

@isidentical isidentical Dec 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know if it possible, contextlib also uses argument clinic but they seperated __class_getitem. I thought there is a catch about this but I can try to do this with argument clinic.

{NULL}
};

Expand Down