Skip to content

bpo-45581: Raise MemoryError in sqlite3.connect if SQLite signals memory error#29171

Merged
ambv merged 3 commits intopython:mainfrom
erlend-aasland:sqlite-open-nomem
Oct 29, 2021
Merged

bpo-45581: Raise MemoryError in sqlite3.connect if SQLite signals memory error#29171
ambv merged 3 commits intopython:mainfrom
erlend-aasland:sqlite-open-nomem

Conversation

@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Oct 22, 2021 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 22, 2021

I view this as a bugfix, so I suggest backporting through to 3.9.

@erlend-aasland erlend-aasland added the type-bug An unexpected behavior, bug, or error label Oct 22, 2021
@erlend-aasland erlend-aasland changed the title bpo-45581: raise MemoryError if sqlite3_open_v2() returns SQLITE_NOMEM bpo-45581: Raise MemoryError in sqlite3.connect if SQLite signals memory error Oct 22, 2021
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 22, 2021

FYI, the Windows x64 failure is unrelated (flakey asyncio test)

@erlend-aasland erlend-aasland requested review from ambv and corona10 and removed request for serhiy-storchaka October 25, 2021 11:09
@ambv ambv merged commit e2e62b3 into python:main Oct 29, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2021

Thanks @erlend-aasland for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2021

Sorry, @erlend-aasland and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e2e62b3808691e15fa44b883270023e42dcad958 3.10

@miss-islington
Copy link
Contributor

miss-islington commented Oct 29, 2021

Sorry @erlend-aasland and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e2e62b3808691e15fa44b883270023e42dcad958 3.9

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 29, 2021
@ambv
[3.10] bpo-45581: Raise MemoryError in sqlite3.connect if SQLite …
cdc75d8 
…signals memory error (pythonGH-29171).

(cherry picked from commit e2e62b3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 29, 2021
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2021

GH-29323 is a backport of this pull request to the 3.10 branch.

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 29, 2021
@ambv
[3.9] bpo-45581: Raise MemoryError in sqlite3.connect if SQLite s…
ac7ba3f 
…ignals memory error (pythonGH-29171).

(cherry picked from commit e2e62b3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@bedevere-bot
Copy link

bedevere-bot commented Oct 29, 2021

GH-29324 is a backport of this pull request to the 3.9 branch.

@erlend-aasland erlend-aasland deleted the sqlite-open-nomem branch October 29, 2021 20:34
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Oct 29, 2021

Thanks, Łukasz!

ambv added a commit that referenced this pull request Oct 29, 2021
@ambv
[3.10] bpo-45581: Raise MemoryError in sqlite3.connect if SQLite …
7e2c0a1 
…signals memory error (GH-29171) (GH-29323)

(cherry picked from commit e2e62b3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
ambv added a commit that referenced this pull request Oct 29, 2021
@ambv
[3.9] bpo-45581: Raise MemoryError in sqlite3.connect if SQLite s…
ed807bf 
…ignals memory error (GH-29171) (GH-29324)

(cherry picked from commit e2e62b3)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
@erlend-aasland erlend-aasland mentioned this pull request May 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal

@corona10 corona10 Awaiting requested review from corona10

@ambv ambv Awaiting requested review from ambv

Assignees

@ambv ambv

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @miss-islington @bedevere-bot @ambv @the-knights-who-say-ni