bpo-45624: make test_graphlib not depend on the iteration order of sets#29233
Merged
ambv merged 1 commit intopython:mainfrom Oct 28, 2021
Merged
bpo-45624: make test_graphlib not depend on the iteration order of sets#29233ambv merged 1 commit intopython:mainfrom
ambv merged 1 commit intopython:mainfrom
Conversation
the current test depended on integer sets being iterated on in a certain fixed order. That order is different on PyPy (insertion based) and could change in CPython in the future in theory. Make the test robust against a different iteration order by sorting.
Contributor
Contributor
|
Sorry @cfbolz and @ambv, I had trouble checking out the |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2021
…ts (pythonGH-29233) the current test depended on integer sets being iterated on in a certain fixed order. That order is different on PyPy (insertion based) and could change in CPython in the future in theory. Make the test robust against a different iteration order by sorting. (cherry picked from commit 7401694) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
|
GH-29292 is a backport of this pull request to the 3.9 branch. |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 28, 2021
…ts (pythonGH-29233) the current test depended on integer sets being iterated on in a certain fixed order. That order is different on PyPy (insertion based) and could change in CPython in the future in theory. Make the test robust against a different iteration order by sorting. (cherry picked from commit 7401694) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
|
GH-29293 is a backport of this pull request to the 3.10 branch. |
ambv
pushed a commit
that referenced
this pull request
Oct 28, 2021
…ts (GH-29233) (GH-29292) the current test depended on integer sets being iterated on in a certain fixed order. That order is different on PyPy (insertion based) and could change in CPython in the future in theory. Make the test robust against a different iteration order by sorting. (cherry picked from commit 7401694) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
ambv
pushed a commit
that referenced
this pull request
Oct 28, 2021
…ts (GH-29233) (GH-29293) the current test depended on integer sets being iterated on in a certain fixed order. That order is different on PyPy (insertion based) and could change in CPython in the future in theory. Make the test robust against a different iteration order by sorting. (cherry picked from commit 7401694) Co-authored-by: Carl Friedrich Bolz-Tereick <cfbolz@gmx.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the current test depended on integer sets being iterated on in a certain
fixed order. That order is different on PyPy (insertion based) and could
change in CPython in the future in theory. Make the test robust against
a different iteration order by sorting.
https://bugs.python.org/issue45624