bpo-45679: Do not cache typing.Literal with more than one type arg#29333
Closed
sobolevn wants to merge 1 commit intopython:mainfrom
Closed
bpo-45679: Do not cache typing.Literal with more than one type arg#29333sobolevn wants to merge 1 commit intopython:mainfrom
typing.Literal with more than one type arg#29333sobolevn wants to merge 1 commit intopython:mainfrom
Conversation
Member
serhiy-storchaka
left a comment
There was a problem hiding this comment.
You actually just make _tp_cache(typed=True) a no-op, but in complex way.
Do not change _tp_cache, change _LiteralSpecialForm.__getitem__ and Literal.
Member
|
And it is expected that the cache is always enabled. See alternative PR #29334. |
Member
Author
|
Yeap, thanks! A bit sad, that I was not quick enough to send a corrected version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue45679