Skip to content

bpo-47120: make JUMP_NO_INTERRUPT relative#32221

Merged
iritkatriel merged 10 commits intopython:mainfrom
iritkatriel:jump_no_interrupt
Apr 5, 2022
Merged

bpo-47120: make JUMP_NO_INTERRUPT relative#32221
iritkatriel merged 10 commits intopython:mainfrom
iritkatriel:jump_no_interrupt

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Mar 31, 2022 •
edited
Loading

iritkatriel
iritkatriel commented Mar 31, 2022
View reviewed changes
brandtbucher
brandtbucher approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@brandtbucher brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. These are always tiny jumps too.

@markshannon
Copy link
Member

markshannon commented Apr 1, 2022 •
edited
Loading

This would be more robust, if you handled it the same way as JUMP_FORWARD/JUMP_BACKWARD.
Add a JUMP_NO_INTERRUPT virtual instruction, and let the assembler emit the correct opcode.
JUMP_NO_INTERRUPT forward is just JUMP_FORWARD.

@iritkatriel
Copy link
Member Author

iritkatriel commented Apr 1, 2022

This would be more robust, if you handled it the same way as JUMP_FORWARD/JUMP_BACKWARD. Add a JUMP_NO_INTERRUPT virtual instruction, and let the assembler emit the correct opcode. JUMP_NO_INTERRUPT forward is just JUMP_FORWARD.

Agreed. I'll update this PR after we've merged #32200 because it would clash otherwise.

@iritkatriel iritkatriel changed the title bpo-47120: replace JUMP_NO_INTERRUPT by the relative JUMP_BACKWARD_NO_INTERRUPT bpo-47120: make JUMP_NO_INTERRUPT relative Apr 2, 2022
@markshannon
Copy link
Member

markshannon commented Apr 5, 2022

Looks good.
Feel free to share the new magic number with #32309. One magic number per day should be enough.

@markshannon
Copy link
Member

markshannon commented Apr 5, 2022

@iritkatriel I've leave it up to you to merge this and #32309 in whichever order you prefer

@iritkatriel iritkatriel merged commit 0aa8d5c into python:main Apr 5, 2022
@iritkatriel iritkatriel mentioned this pull request Apr 15, 2022
Closed
@iritkatriel iritkatriel deleted the jump_no_interrupt branch May 20, 2022 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

+1 more reviewer

@raghavthind2005 raghavthind2005 raghavthind2005 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@iritkatriel @markshannon @brandtbucher @raghavthind2005 @the-knights-who-say-ni @bedevere-bot