bpo-47120: make POP_JUMP_IF_TRUE/FALSE/NONE/NOT_NONE relative#32400
bpo-47120: make POP_JUMP_IF_TRUE/FALSE/NONE/NOT_NONE relative#32400markshannon merged 16 commits intopython:mainfrom
Conversation
|
This branch includes the NONE/NOT_NONE commits, so look at the last commit to see the TRUE/FALSE part. |
markshannon
left a comment
There was a problem hiding this comment.
I've suggested some bit hacks to tidy up the compare-and-jump specializations.
|
Looks good to me. Want to run the buildbots on it before merging? There are more bit hacks we could do to streamline the jump computation and evalbreaker checks, but that's for another PR. |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4e29993 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
As we predicted, this change eliminates 90% of the jumps with extended args: Static stats Before: After: |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 09ba3bc 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit ec4dcf2 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
|
The buildbots are happy. |
https://bugs.python.org/issue47120