Skip to content

gh-91984: Appended '\n' to test strings in test_argparse.py(#91984)#91986

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
AbhigyanBose:fix-issue-91984
Apr 28, 2022
Merged

gh-91984: Appended '\n' to test strings in test_argparse.py(#91984)#91986
serhiy-storchaka merged 1 commit intopython:mainfrom
AbhigyanBose:fix-issue-91984

Conversation

@AbhigyanBose
Copy link
Contributor

@AbhigyanBose AbhigyanBose commented Apr 27, 2022 •
edited by serhiy-storchaka
Loading

#gh-91984: Appended '\n' to test strings in test_argparse.py(#91984)

Implementing the fix proposed in the issue description in #91984

Adding '\n' to the end of:

cpython/Lib/test/test_argparse.py

Line 2268 in b733708

foo

and

cpython/Lib/test/test_argparse.py

Line 2285 in b733708

{}

Closes #91984.

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Apr 27, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Apr 28, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I was going to fix this a long time ago, but could not find a free time for this.

@AbhigyanBose
Copy link
Contributor Author

AbhigyanBose commented Apr 28, 2022

@serhiy-storchaka Could you approve the test workflows ?

@serhiy-storchaka serhiy-storchaka merged commit 88dd227 into python:main Apr 28, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2022

Thanks @AbhigyanBose for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2022

Thanks @AbhigyanBose for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2022

Sorry, @AbhigyanBose and @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 88dd22795925a8f47d38737ca8067eeb3f0a13aa 3.9

@miss-islington
Copy link
Contributor

miss-islington commented Apr 28, 2022

Sorry @AbhigyanBose and @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 88dd22795925a8f47d38737ca8067eeb3f0a13aa 3.10

@AbhigyanBose AbhigyanBose deleted the fix-issue-91984 branch April 28, 2022 13:11
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_argparse.py trailing spaces within test strings removed by make patchcheck if file is modified

4 participants

@AbhigyanBose @miss-islington @serhiy-storchaka @bedevere-bot