Skip to content

gh-92107: Forbid specialization of namedtuple types#92117

Closed
serhiy-storchaka wants to merge 3 commits intopython:mainfrom
serhiy-storchaka:collections-namedtuple-non-generic
Closed

gh-92107: Forbid specialization of namedtuple types#92117
serhiy-storchaka wants to merge 3 commits intopython:mainfrom
serhiy-storchaka:collections-namedtuple-non-generic

Conversation

@serhiy-storchaka
Copy link
Member

Closes #92107.

@serhiy-storchaka serhiy-storchaka marked this pull request as draft May 1, 2022 14:51
@serhiy-storchaka
Copy link
Member Author

There was found a bug in tests: SplitResult and ParseResult are not generic, according to typeshed.

#92115 is required to make new tests passing.

@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review May 2, 2022 05:31
@JelleZijlstra
Copy link
Member

As discussed on the issue, we should keep allowing this. Could you instead add tests that ensure specialization works?

@serhiy-storchaka
Copy link
Member Author

Closed in favor of #92304.

@serhiy-storchaka serhiy-storchaka deleted the collections-namedtuple-non-generic branch May 4, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specialization of namedtuple types

3 participants