Skip to content

Fix Incorrect JSX Syntax in Knight Component Example#3647

Open
mrbadri wants to merge 1 commit intoreact-dnd:mainfrom
mrbadri:main
Open

Fix Incorrect JSX Syntax in Knight Component Example#3647
mrbadri wants to merge 1 commit intoreact-dnd:mainfrom
mrbadri:main

Conversation

@mrbadri
Copy link

@mrbadri mrbadri commented Oct 17, 2024

Fix Incorrect JSX Syntax in Knight Component Example

This PR fixes an issue with the JSX syntax in the Knight component example provided in the documentation. The problem was caused by a misplaced closing parenthesis in the return block, which was breaking the component's functionality.

Changes:

  • Removed the extra comma in the JSX to fix the closing parenthesis issue.
  • Updated the example to reflect the correct syntax.

Issue:

Closes #3646

@mrbadri mrbadri requested a review from darthtrevino as a code owner October 17, 2024 16:16
@mrbadri
Copy link
Author

mrbadri commented Dec 7, 2024

Hi @darthtrevino Could you please take a look at this PR when you have a moment?
Your feedback would be greatly appreciated! 🙌

@pieralukasz
Copy link
Collaborator

@mrbadri hi! This one will be merged after we replace the secret key and make an action for a docsite running, here 3653.

@mrbadri
Copy link
Author

mrbadri commented Dec 7, 2024

@mrbadri hi! This one will be merged after we replace the secret key and make an action for a docsite running, here 3653.

Hi @pieralukasz, thank you so much for reviewing my PR! I really appreciate it, and I’ve got it.

@AurelianSpodarec
Copy link

Hey, any updates?

@mrbadri
Copy link
Author

mrbadri commented Feb 28, 2025

Hi @darthtrevino, hope you’re doing well! Could you please review my pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect JSX syntax in the Knight component example

3 participants