Skip to content

[MRG] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure or warning #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmike merged 4 commits into from
Mar 9, 2017
Merged

[MRG] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure or warning #2632

kmike merged 4 commits into from
Mar 9, 2017

Conversation

@redapple
Copy link
Contributor

@redapple redapple commented Mar 7, 2017

Related to #2433 (comment)

@codecov-io
Copy link

codecov-io commented Mar 9, 2017 •
edited
Loading

Codecov Report

Merging #2632 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2632      +/-   ##
==========================================
+ Coverage   84.17%   84.18%   +<.01%     
==========================================
  Files         162      162              
  Lines        9088     9093       +5     
  Branches     1347     1348       +1     
==========================================
+ Hits         7650     7655       +5     
  Misses       1177     1177              
  Partials      261      261
Impacted Files Coverage Δ
scrapy/commands/runspider.py 73.52% <100%> (+0.39%) ✅
scrapy/commands/list.py 80% <100%> (ø) ✅
scrapy/settings/default_settings.py 98.63% <100%> (ø) ✅
scrapy/commands/version.py 91.11% <100%> (ø) ✅
scrapy/commands/settings.py 72.72% <100%> (ø) ✅
scrapy/commands/startproject.py 100% <100%> (ø) ✅
scrapy/spiderloader.py 100% <100%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3f8f3d...9628a73. Read the comment docs.

@redapple redapple changed the title [WIP] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure and warning Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure and warning Mar 9, 2017
@redapple
Copy link
Contributor Author

redapple commented Mar 9, 2017

@vshlapakov , would this change work for you?

@redapple redapple added this to the v1.4 milestone Mar 9, 2017
kmike
kmike reviewed Mar 9, 2017
View reviewed changes
scrapy/settings/default_settings.py
SCHEDULER_PRIORITY_QUEUE = 'queuelib.PriorityQueue'

SPIDER_LOADER_CLASS = 'scrapy.spiderloader.SpiderLoader'
SPIDER_LOADER_WARN_ONLY = False
Copy link
Member

@kmike kmike Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add docs for this option? Or are you waiting for @vshlapakov's feedback?

Copy link
Contributor Author

@redapple redapple Mar 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmike , docs updated.

@redapple
Copy link
Contributor Author

redapple commented Mar 9, 2017

Sorry, I'll add some doc.
But yes, I was also asking if this solution would work (name of option still up of course)

@redapple redapple changed the title Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure and warning [WIP] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure and warning Mar 9, 2017
@vshlapakov
Copy link

vshlapakov commented Mar 9, 2017

@redapple The changes looks good to me, thanks Paul! cc @chekunkov

@redapple redapple changed the title [WIP] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure and warning [WIP] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure or warning Mar 9, 2017
@chekunkov
Copy link
Contributor

chekunkov commented Mar 9, 2017

LGTM

@redapple
Copy link
Contributor Author

redapple commented Mar 9, 2017 •
edited
Loading

phew, f2ac24e was the whole point of this... ;)

@redapple redapple changed the title [WIP] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure or warning [MRG] Add SPIDER_LOADER_WARN_ONLY to toggle between spiderloader failure or warning Mar 9, 2017
@kmike kmike merged commit 9c69e90 into scrapy:master Mar 9, 2017
@kmike
Copy link
Member

kmike commented Mar 9, 2017

Thanks @redapple, @vshlapakov and @chekunkov!

@Digenis Digenis mentioned this pull request Mar 10, 2017
Closed
@redapple redapple mentioned this pull request Mar 10, 2017
Merged
This was referenced Mar 13, 2017
Merged
Merged
Closed
@wRAR wRAR mentioned this pull request Jan 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmike kmike kmike left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

5 participants

@redapple @codecov-io @vshlapakov @chekunkov @kmike