#1143. Char literals does not take escape sequences into account#1144
Merged
glennblock merged 2 commits intoscriptcs:devfrom Jan 3, 2017
Merged
#1143. Char literals does not take escape sequences into account#1144glennblock merged 2 commits intoscriptcs:devfrom
glennblock merged 2 commits intoscriptcs:devfrom
Conversation
…ak another unit test that is checking that broken input is to be accepted
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1143. The single quoted literal (char literal) does not work when there is more than one literal char in the string, which could be true if there are escape sequences involved.
I copied the code from the double quoted literal (string literal) token and this resolves the issue I was seeing. I had to change the code slightly to make the ShouldNotFailOnIdentifyingCharactersAsToken test succeed, as it seems the lexer needs to support some broken input (I am not sure I captured the real intent of the test though).
I added a unit test to ScriptLexerTests to show the case. It should fail without the fix and succeed with the fix