Adding custom package manager to allow forcing framework target version#1215
Adding custom package manager to allow forcing framework target version#1215glennblock merged 2 commits intoscriptcs:devfrom
Conversation
|
One suggestion I have would be to consider pulling the See here for an example: https://github.com/Wyamio/Wyam/blob/353f72a84cea7c2747517e3b534fa8d8aaaa5fc2/src/core/Wyam.Configuration/NuGet/PackageInstaller.cs#L42 |
|
Right now we only support one, but that is a good point to consider if we end up getting support for .NET Core at some point. |
|
@daveaglick does it make sense for us to upgrade to the NuGet 3 client? Currently we only support .NET 4.5, though we are going to move to require 4.6 soon. |
|
@daveaglick thanks for the link, I will use that approach. |
|
So are you still on the v2 NuGet APIs? If so, I would suggest moving to v3. AFAIK, the v2 APIs aren't getting any more love. There's a lot of breakage though. I'll take a look tomorrow to see what it might take to bump you up. |
|
@daveaglick updated. Works beautifully, thanks! |
|
Allright, based on all MY testing (and the fact that Travis and TC pass) I am going to just go and merge this. I'll ask for forgiveness later if that was a bad idea. |
Fix for #1213